Patch attached.
From ac8af289c283aaf44d7ac42e1b8bfeecc417e59c Mon Sep 17 00:00:00 2001
From: Martin Basti <[email protected]>
Date: Thu, 17 Dec 2015 16:07:10 +0100
Subject: [PATCH] Enable pylint unbalanced-tuple-unpacking check
Enables check and fixes one issue.
get_entries can be replaced by get_entry, filter is not needed because
check of 'originfilter' attribute is done later.
---
install/tools/ipa-managed-entries | 3 +--
make-lint | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/install/tools/ipa-managed-entries b/install/tools/ipa-managed-entries
index c786e883ad967b938934c6f568cd3401c4fa278e..8a89da8a8a3ff17dd23ff760876e93e0f73d73f7 100755
--- a/install/tools/ipa-managed-entries
+++ b/install/tools/ipa-managed-entries
@@ -132,8 +132,7 @@ def main():
disabled = True
try:
- [entry] = conn.get_entries(def_dn, conn.SCOPE_BASE,
- filter, ['originfilter'])
+ entry = conn.get_entry(def_dn)
disable_attr = '(objectclass=disable)'
try:
org_filter = entry.single_value.get('originfilter')
diff --git a/make-lint b/make-lint
index b1780f94adcb56e1b2c5ec014ad73d203b96c351..df829580bb56098d61a8a875d2a5e6f70c75f4d2 100755
--- a/make-lint
+++ b/make-lint
@@ -279,7 +279,6 @@ def main():
linter.set_option('disable', 'unused-argument')
linter.set_option('disable', 'unused-variable')
linter.set_option('disable', 'useless-else-on-loop')
- linter.set_option('disable', 'unbalanced-tuple-unpacking')
linter.set_option('enable', 'C')
linter.set_option('disable', 'bad-classmethod-argument')
--
2.5.0
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
