On 13.01.2016 16:03, Simo Sorce wrote:
On Wed, 2016-01-13 at 15:49 +0100, Martin Basti wrote:
On 13.01.2016 15:31, Martin Babinsky wrote:
On 01/13/2016 03:30 PM, Simo Sorce wrote:
On Wed, 2016-01-13 at 14:02 +0100, Martin Babinsky wrote:
On 01/05/2016 11:19 PM, Simo Sorce wrote:
On Tue, 2016-01-05 at 16:15 -0500, Simo Sorce wrote:
The LDAP context was not checked on the first api call and a
context may
be null on some error conditions (LDAP server unreachable).

Always check that we have a valid context before calling the ldap
API.

Builds abut it is untested.
Forgot to mention that this bug affects all 4.x versions and should
probably be backported on all maintained branches.

I opened a bug to track it too:
https://fedorahosted.org/freeipa/ticket/5577

Simo.

ACK. Please include the ticket URL in the commit message.

Could you add it when pushing ?

Unless you need some other change in the patch it will be less churn
that way.

Simo.

Yes we could. I didn't realize that, sorry for the noise.

I do not know where to push it, ticket is still in needs triage, it has
not been decided where it should go.
It definitely goes in master. You can push elsewhere as well later.

Simo.

Pushed to master: 2144b1eeb789639b8a3df287b580aeb6196188a8

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to