On 13.01.2016 17:59, Rob Crittenden wrote:
Martin Babinsky wrote:
fixes https://fedorahosted.org/freeipa/ticket/5584
In order to ensure consistent behavior with ipa-client-install, I opted
to reuse the configure_openldap_conf() function and restoring the config
from client sysrestore before modifying it.
If you think this approach is not optimal please propose an alternative
solution.
You could also just do an action set on URI to change the value, right?
It would need a new function but it would be very small.
If you do end up keeping this I'd want a new commit message for moving
the code to include why you're moving it (to avoid the need to deference
the ticket).
rob
NACK
Traceback (most recent call last):
File "./makeapi", line 459, in <module>
sys.exit(main())
File "./makeapi", line 430, in main
api.finalize()
File "/root/freeipa/ipalib/plugable.py", line 658, in finalize
self.__do_if_not_done('load_plugins')
File "/root/freeipa/ipalib/plugable.py", line 372, in __do_if_not_done
getattr(self, name)()
File "/root/freeipa/ipalib/plugable.py", line 536, in load_plugins
self.import_plugins(module)
File "/root/freeipa/ipalib/plugable.py", line 574, in import_plugins
module = importlib.import_module(name)
File "/usr/lib64/python2.7/importlib/__init__.py", line 37, in
import_module
__import__(name)
File "/root/freeipa/ipalib/plugins/baseuser.py", line 33, in <module>
from ipapython.ipautil import ipa_generate_password
File "/root/freeipa/ipapython/ipautil.py", line 49, in <module>
from ipaclient.ipachangeconf import IPAChangeConf
ImportError: No module named ipaclient.ipachangeconf
Traceback (most recent call last):
File "./makeaci", line 35, in <module>
from ipapython.ipaldap import LDAPClient
File "/root/freeipa/ipapython/ipaldap.py", line 41, in <module>
from ipapython.ipautil import (
File "/root/freeipa/ipapython/ipautil.py", line 49, in <module>
from ipaclient.ipachangeconf import IPAChangeConf
ImportError: No module named ipaclient.ipachangeconf
Makefile:138: recipe for target 'version-update' failed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
