DS instance install should fail immediately after setup-ds.pl fail.

tickets: #2539, #3720, #5607

https://fedorahosted.org/freeipa/ticket/2539
--
Petr Vobornik
From 3de95dda405e4679fe55255d6ddb234b011c85e7 Mon Sep 17 00:00:00 2001
From: Petr Vobornik <pvobo...@redhat.com>
Date: Thu, 21 Jan 2016 18:23:26 +0100
Subject: [PATCH] stop installer when setup-ds.pl fail

DS instance install should fail immediately after setup-ds.pl fail.

tickets: #2539, #3720, #5607

https://fedorahosted.org/freeipa/ticket/2539
---
 ipaserver/install/dsinstance.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipaserver/install/dsinstance.py b/ipaserver/install/dsinstance.py
index a58b0f7c2f1a6baae09e38695b8e569d7495d524..8b91042f8e2f23019b7bfad67193bb4c2ad60454 100644
--- a/ipaserver/install/dsinstance.py
+++ b/ipaserver/install/dsinstance.py
@@ -543,7 +543,7 @@ class DsInstance(service.Service):
             ipautil.run(args)
             root_logger.debug("completed creating ds instance")
         except ipautil.CalledProcessError as e:
-            root_logger.critical("failed to create ds instance %s" % e)
+            raise RuntimeError("failed to create ds instance %s" % e)
 
         # check for open port 389 from now on
         self.open_ports.append(389)
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to