On 01/19/2016 05:56 PM, Milan Kubík wrote:
On 01/19/2016 05:31 PM, Milan Kubík wrote:
Patch attached.



This actually has a ticket opened. Patch with fixed commit message. ;)

--
Milan Kubik




Hi Milan,

for the step 1 installation I would rather reuse the tasks:install_master function which already does (nearly) all CLI option-related magic. You can extend its signature by adding a parameter to pass on additional options like this:

--- a/ipatests/test_integration/tasks.py
+++ b/ipatests/test_integration/tasks.py
@@ -258,7 +258,7 @@ def enable_replication_debugging(host):
                      stdin_text=logging_ldif)


-def install_master(host, setup_dns=True, setup_kra=False):
+def install_master(host, setup_dns=True, setup_kra=False, extra_args=()):
     host.collect_log(paths.IPASERVER_INSTALL_LOG)
     host.collect_log(paths.IPACLIENT_INSTALL_LOG)
     inst = host.domain.realm.replace('.', '-')
@@ -284,6 +284,8 @@ def install_master(host, setup_dns=True, setup_kra=False):
             '--auto-reverse'
         ])

+    args.extend(extra_args)
+
     host.run_command(args)
     enable_replication_debugging(host)
     setup_sssd_debugging(host)

--
Martin^3 Babinsky

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to