On 21.1.2016 15:04, Martin Babinsky wrote:
On 01/21/2016 02:51 PM, Jan Cholasta wrote:
On 21.1.2016 14:45, Martin Babinsky wrote:
On 01/21/2016 02:21 PM, Petr Vobornik wrote:
On 01/21/2016 01:53 PM, Martin Babinsky wrote:
this patch ensures that promoted replicas in CA-less topology have
correct settings in their default.conf.

I couldn't find any ticket for this issue, should I file one so that
this patch can land in 4-3 branch?


yes

New ticket here: https://fedorahosted.org/freeipa/ticket/5626

I have also attached the ticket URL to the commit message.

Why so much code for such a simple change? Please keep the style
consistent with the code in install.install() and
replicainstall.install().


It did not occur to me as much code, the logic was equivalent to the
stuff other installers do but bit more concise.

But attaching updated patch in common style anyway.

Thanks, ACK.

Pushed to:
master: 7dae5c09d5a6bf084661511bef4811223da64252
ipa-4-3: b63505ef765768b7cbcfc84983c249269ab8b788

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to