On 01/25/2016 01:55 PM, Pavel Vomacka wrote:
Hello everyone,

I just made a patch for the
https://fedorahosted.org/freeipa/ticket/5428 ticket. The patch adds
tool tips to the buttons in detail views. The text of new tool tips
is written in the comment of the ticket.

Pavel Vomacka Intern

Hi, there are few issues, NACK.

1. this patch uses tabs instead of spaces, previous was correct

2. code which focuses first invalid field could be replaced by:

3. there is a convention that field and widget names uses the same name as the param, therefore 'textarea_cert' should be 'csr'. There is no convention for messages in html widget but it might be better to use a name reflecting purpose and not implementation. Instead of 'message_html_widget' use 'instructions' or just 'message' - consistent with spec option.

Also I've filed: https://fedorahosted.org/freeipa/ticket/5652
Petr Vobornik

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to