On 21.01.2016 12:59, Oleg Fayans wrote:


Hello,

1)
I'm not sure if it is bug or it is related to this patch, but there is missing symetry in test_caless, I see there apply fixes but not unapply_fixes

ipatests/ipa-test-task:378:            tasks.unapply_fixes(host)
ipatests/test_integration/tasks.py:201:def unapply_fixes(host):
ipatests/test_integration/tasks.py:646:    unapply_fixes(host)
ipatests/test_integration/tasks.py:654:    unapply_fixes(host)
ipatests/test_integration/tasks.py:997:    unapply_fixes(replica)
ipatests/test_integration/test_legacy_clients.py:373: tasks.unapply_fixes(cls.legacy_client)


ipatests/test_integration/tasks.py:91:def apply_common_fixes(host, fix_resolv=True): ipatests/test_integration/tasks.py:269: apply_common_fixes(host, fix_resolv=False)
ipatests/test_integration/tasks.py:320: apply_common_fixes(replica)
ipatests/test_integration/tasks.py:386: apply_common_fixes(client)
ipatests/test_integration/test_caless.py:101: tasks.apply_common_fixes(host)
ipatests/test_integration/test_legacy_clients.py:361: tasks.apply_common_fixes(cls.legacy_client)

2)
IMO unapply_fixes is called twice for replica uninstall

     uninstall_master(replica)
+    unapply_fixes(replica)

uninstall_master calls unapply_fixes() too

3)
what is purpose of prepare_host? I saw it used only in test_forced_client_reenrollment.py
Which test was failing?

4)
in test_forced_client_reenrollment.py there is direct call of prepare_host, but this is also install_client that calls prepare_host too (added by your patch)

Martin
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to