On 29.01.2016 14:42, Christian Heimes wrote:
On 2016-01-28 09:47, Martin Basti wrote:
On 22.01.2016 12:32, Martin Kosek wrote:
On 01/21/2016 04:21 PM, Christian Heimes wrote:
The list of supported TLS cipher suites in /etc/httpd/conf.d/nss.conf
has been modernized. Insecure or less secure algorithms such as RC4,
DES and 3DES are removed. Perfect forward secrecy suites with ephemeral
ECDH key exchange have been added. IE 8 on Windows XP is no longer
The list of enabled cipher suites has been generated with the script
The supported suites are currently:
Thanks for the patch! I updated the ticket to make sure this change is
I'm not sure if I'm the right person to do review on this, but I will
Your patch adds whitespace error
Applying: Modernize mod_nss's cipher suites
/home/mbasti/work/freeipa-devel/.git/rebase-apply/patch:52: new blank
line at EOF.
warning: 1 line adds whitespace errors.
+import urllib.request # pylint: disable=E0611
Please specify pylint disabled check by name
in this upgrade, is there any possibility that ciphers might be upgraded
again in future? (IMO yes).
I think, it can be better to store revision of change instead of boolean
LAST_REVISION = 1
if revision >= LAST_REVISION:
Thanks for the review. I have addressed the problems. Instead of a
revision number I'm using a date string. The sysupgrade module only
stores str and bool. With a date-based revision it's easy to see when
the cipher suite was checked last time.
1) Pylint :-)
+ with urllib.request.urlopen(SOURCE) as r: # pylint: disable=E1101
+ if revision == httpinstance.NSS_CIPHER_REVISION:
may happen a case where just comparation with '==' can cause a issues
(docker world)? Should not be there rather '>='?
+ root_logger.info("Cipher suite already updated")
Sorry that I did not noticed earlier, this should be just debug level,
IMO this message is not so important, it will cause only mess on output
(we already have plenty of unneeded info messages in upgrade, they will
be fixed once)
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code