On 01/29/2016 10:58 AM, Pavel Vomacka wrote:



On 01/28/2016 07:28 PM, Petr Vobornik wrote:
Hi, there are few issues, NACK.

1. this patch uses tabs instead of spaces, previous was correct
Fixed.

2. code which focuses first invalid field could be replaced by:
  widget_mod.focus_invalid(that);
The old loop is replaced by this method.

3. there is a convention that field and widget names uses the same
name as the param, therefore 'textarea_cert' should be 'csr'. There is
no convention for messages in html widget but it might be better to
use a name reflecting purpose and not implementation. Instead of
'message_html_widget' use 'instructions' or just 'message' -
consistent with spec option.

Fixed. I chose 'message' instead of 'message_html_widget'.
Also I've filed: https://fedorahosted.org/freeipa/ticket/5652
Pavel Vomacka



ACK

Pushed to master: fb3b7f7d93060d42e9cc79768f72e0b2d4b0481f
--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to