On 02/26/2016 04:38 PM, Lukáš Hellebrandt wrote: > On 02/26/2016 01:30 PM, Martin Kosek wrote: >> Greetings, welcome! >> >> On 02/26/2016 01:17 PM, Lukáš Hellebrandt wrote: >> ... >>> Btw, is there some better place to share patches than a pasting tool? >>> Maybe some form of pull request? >> >> There is :-) Please see advise here: >> >> http://www.freeipa.org/page/Contribute/Code#Submit_a_patch >> >> It has more information on top of submitting patches. For example, I think it >> would actually make sense to start with a design page where you would >> describe >> the use cases, design, APIs, etc: >> >> http://www.freeipa.org/page/Contribute/Code#Prepare >> >> Martin >> > > Should I send it as an attachment?
Right. > Ok, sending, but do not apply it yet > (even if you don't find bugs), I just need some feedback - not > everything is done yet. The patch looks OK, but there is not much in the patch anyway, yet. But as I written above I would suggest starting with a design document you share with the other developers, so that you can be given an advise and feedback regarding the approach and overall design. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code