On 02/29/2016 02:59 PM, Tomas Babej wrote:



On 02/29/2016 02:04 PM, Martin Babinsky wrote:
On 02/25/2016 02:13 PM, Tomas Babej wrote:
Hi,

Dash should be one of the allowed characters in the netbios names,
so relax the too strict validation.

Note: the set of allowed characters might expand in the future

https://fedorahosted.org/freeipa/ticket/5286

Tomas




NACK, since this patch breaks the interactive installation of adtrust,
see the following log: http://fpaste.org/331088/56750906/

Keep in mind that the argument of any is first instantiated and then
each element is tested. Since during interactive installation there is a
possibility in the current code that check_netbios_name receives None as
argument. You will have to correct this somehow.


Good catch. My original patch indeed breaks the interactive installation
on a clean machine where no netbios name has been specified explicitly.

Fixed, attaching patches for both branches.

Tomas

ACK

--
Martin^3 Babinsky

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to