On 29.2.2016 17:14, Petr Viktorin wrote:
On 02/29/2016 08:12 AM, Jan Cholasta wrote:
On 26.2.2016 17:14, Petr Viktorin wrote:
On 02/22/2016 12:37 PM, Petr Viktorin wrote:
These fixes are needed for the "happy path" of ipa-client-install
--server on Python 3.
Could someone please look at these patches?
It seems this bit:
+ [cn] = lres.raw['cn']
Traceback (most recent call last):
File "/sbin/ipa-client-install", line 3099, in <module>
File "/sbin/ipa-client-install", line 3080, in main
rval = install(options, env, fstore, statestore)
File "/sbin/ipa-client-install", line 2769, in install
File "/usr/lib/python2.7/site-packages/ipalib/rpc.py", line 145, in
line 130, in del_key
assert isinstance(key, str)
because realm is returned as unicode from ipadiscovery.
1) Instead of decoding when the type is bytes in get_ipa_basedn(), read
attribute values from 'entry.raw' rather than 'entry' and decode always.
2) get_ipa_basedn() is used only in ipadiscovery, perhaps we should move
I did that in an extra patch, mainly to make the diff more meaningful.
OK. The patch needs a rebase for ipa-4-3, there is a stray
get_ipa_basedn import in install/migration/migration.py.
Patch 0773: ACK, but the patch does not apply on ipa-4-3.
Patch 0774: ACK.
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code