ACK. Thank you! - alich - ----- Original Message ----- > From: "Filip Skola" <fsk...@redhat.com> > To: "Aleš Mareček" <amare...@redhat.com> > Cc: freeipa-devel@redhat.com, "Milan Kubík" <mku...@redhat.com> > Sent: Wednesday, February 24, 2016 8:07:55 PM > Subject: Re: [Freeipa-devel] [PATCH] 0007 Refactor test_sudocmd_plugin > > Hi, > > these problems have been fixed. > > F. > > ----- Original Message ----- > > NACK. > > Some little changes still required: > > * fixing the pep8 errors > > * fixing the wrong comment > > > > [root@master2 freeipa]# pep8 ipatests/test_xmlrpc/test_sudocmd_plugin.py > > ipatests/test_xmlrpc/test_sudocmd_plugin.py:94:80: E501 line too long (87 > > > 79 characters) > > ipatests/test_xmlrpc/test_sudocmd_plugin.py:97:80: E501 line too long (87 > > > 79 characters) > > ipatests/test_xmlrpc/test_sudocmd_plugin.py:134:80: E501 line too long (80 > > > > > 79 characters) > > > > [root@master2 freeipa]# pep8 ipatests/test_xmlrpc/tracker/sudocmd_plugin.py > > ipatests/test_xmlrpc/tracker/sudocmd_plugin.py:14:80: E501 line too long > > (81 > > > 79 characters) > > > > [root@master2 freeipa]# grep 'Class for' > > ipatests/test_xmlrpc/tracker/sudocmd_plugin.py > > """ Class for host plugin like tests """ > > > > > > ----- Original Message ----- > > > From: "Filip Skola" <fsk...@redhat.com> > > > To: "Aleš Mareček" <amare...@redhat.com> > > > Cc: freeipa-devel@redhat.com, "Milan Kubík" <mku...@redhat.com> > > > Sent: Monday, February 22, 2016 1:59:43 PM > > > Subject: Re: [Freeipa-devel] [PATCH] 0007 Refactor test_sudocmd_plugin > > > > > > Hi, > > > > > > sudocmd tracker has been created. > > > > > > Filip > > > > > > ----- Original Message ----- > > > > NACK. > > > > > > > > "create_sudocmd" and "delete_sudocmd" should be placed in Tracker. So > > > > this > > > > patch should create the tracker as well. > > > > > > > > ----- Original Message ----- > > > > > From: "Filip Skola" <fsk...@redhat.com> > > > > > To: freeipa-devel@redhat.com > > > > > Sent: Monday, January 25, 2016 3:57:25 PM > > > > > Subject: [Freeipa-devel] [PATCH] 0007 Refactor test_sudocmd_plugin > > > > > > > > > > Hello, > > > > > > > > > > attaching refactored sudocmd_plugin. > > > > > > > > > > Filip > > > > > -- > > > > > Manage your subscription for the Freeipa-devel mailing list: > > > > > https://www.redhat.com/mailman/listinfo/freeipa-devel > > > > > Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code > > > > > > > > > >
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
