ACK. Thank you! Master push: Make sure it will go *after or together with* the previous patch from Filip, #0007, thanks!
- alich - ----- Original Message ----- > From: "Filip Skola" <fsk...@redhat.com> > To: "Aleš Mareček" <amare...@redhat.com> > Cc: freeipa-devel@redhat.com, "Milan Kubík" <mku...@redhat.com> > Sent: Wednesday, February 24, 2016 8:13:03 PM > Subject: Re: [Freeipa-devel] [PATCH] 0008 Refactor test_sudocmdgroup_plugin, > create SudoCmdGroupTracker > > Hi, > > fixed. To be honest, I left that +1char longer lines there on purpose. IMHO > it brings better readability and pep8 *.py | wc -l in test_xmlrpc dir > returns an overwhelming number anyway. But yeah, some of these weren't > really necessary...so I changed them all :) > > This patch is dependent on 0007-3 patch. > > Filip > > ----- Original Message ----- > > NACK. > > > > > > [root@master2 test_xmlrpc]# pep8 test_sudocmdgroup_plugin.py > > test_sudocmdgroup_plugin.py:26:80: E501 line too long (80 > 79 characters) > > test_sudocmdgroup_plugin.py:70:80: E501 line too long (80 > 79 characters) > > test_sudocmdgroup_plugin.py:76:80: E501 line too long (80 > 79 characters) > > test_sudocmdgroup_plugin.py:84:80: E501 line too long (80 > 79 characters) > > test_sudocmdgroup_plugin.py:90:80: E501 line too long (80 > 79 characters) > > test_sudocmdgroup_plugin.py:98:80: E501 line too long (80 > 79 characters) > > test_sudocmdgroup_plugin.py:104:80: E501 line too long (80 > 79 characters) > > test_sudocmdgroup_plugin.py:166:80: E501 line too long (80 > 79 characters) > > test_sudocmdgroup_plugin.py:180:80: E501 line too long (80 > 79 characters) > > test_sudocmdgroup_plugin.py:186:80: E501 line too long (84 > 79 characters) > > [root@master2 test_xmlrpc]# pep8 tracker/sudocmdgroup_plugin.py > > tracker/sudocmdgroup_plugin.py:36:80: E501 line too long (82 > 79 > > characters) > > tracker/sudocmdgroup_plugin.py:42:80: E501 line too long (82 > 79 > > characters) > > tracker/sudocmdgroup_plugin.py:46:80: E501 line too long (85 > 79 > > characters) > > tracker/sudocmdgroup_plugin.py:55:80: E501 line too long (82 > 79 > > characters) > > tracker/sudocmdgroup_plugin.py:64:80: E501 line too long (82 > 79 > > characters) > > > > > > > > ----- Original Message ----- > > > From: "Filip Skola" <fsk...@redhat.com> > > > To: "Aleš Mareček" <amare...@redhat.com> > > > Cc: freeipa-devel@redhat.com, "Milan Kubík" <mku...@redhat.com> > > > Sent: Monday, February 22, 2016 3:41:36 PM > > > Subject: Re: [Freeipa-devel] [PATCH] 0008 Refactor > > > test_sudocmdgroup_plugin, create SudoCmdGroupTracker > > > > > > Hi, > > > > > > the test has been updated so it now uses the SudoCmdTracker (from the > > > previous patch). > > > > > > Filip > > > > > > ----- Original Message ----- > > > > NACK. > > > > > > > > "create_sudocmd" and "delete_sudocmd" should be imported from Tracker, > > > > not > > > > from the previous test (sudocmd_plugin). > > > > > > > > - alich - > > > > > > > > ----- Original Message ----- > > > > > From: "Filip Skola" <fsk...@redhat.com> > > > > > To: freeipa-devel@redhat.com > > > > > Sent: Thursday, January 28, 2016 12:49:17 PM > > > > > Subject: [Freeipa-devel] [PATCH] 0008 Refactor > > > > > test_sudocmdgroup_plugin, > > > > > create SudoCmdGroupTracker > > > > > > > > > > Hi, > > > > > > > > > > sending the next sudo patch. This one depends on the previous one > > > > > (sudocmd_plugin). > > > > > > > > > > Filip > > > > > > > > > > -- > > > > > Manage your subscription for the Freeipa-devel mailing list: > > > > > https://www.redhat.com/mailman/listinfo/freeipa-devel > > > > > Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code > > > > > > > > > > -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
