On 28.01.2016 17:32, Martin Babinsky wrote:
On 01/28/2016 05:06 PM, Tomas Babej wrote:

On 01/28/2016 04:44 PM, Martin Babinsky wrote:
On 01/28/2016 03:20 PM, Tomas Babej wrote:

On 01/27/2016 03:58 PM, Martin Babinsky wrote:
On 01/18/2016 06:43 PM, Martin Babinsky wrote:
A little patch that should make some future pylint errors disappear.

Attaching updated patch that does not promote direct molestation of
instance dictionaries.

Patch looks good, one thing I am concerened about though is that
__todict__ now returns a direct reference to the internal, mutable dict,
and no longer a (shallow) copy.

Maybe we should use dict.copy() there?


Ah I didn't realize that. Fixed in updated patch.

Nitpick: Sorry for being misleading - I did not mean to suggest invoking
the method using the dict type directly. While being equivalent, the


it's less idiomatic than:



Ah sorry I forgot how to python again.

Attaching patch.

Bump for review
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to