On 26.02.2016 07:25, Jan Cholasta wrote:
Hi,

On 25.2.2016 18:05, Martin Basti wrote:
https://fedorahosted.org/freeipa/ticket/5680

Patch attached.

NACK.

For python 3, the ldap module is provided by python3-pyldap.

Any reason for the random ordering? The requires are not alphabetically ordered, so I would prefer if you just appended the new ones.
updated patch attached.

There are missing as well as redundant requires in other packages, shouldn't we fix these too?
Please file ticket for it.

Honza

Martin^2
From 439d0bcd247c64e6c41820b4a554fb41ed500a0c Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Thu, 25 Feb 2016 17:47:10 +0100
Subject: [PATCH] spec: Add missing dependencies to python*-ipalib package

Standalone instalation of python*-ipalib packages does not pull all
required packages and results into import errors.

https://fedorahosted.org/freeipa/ticket/5680
---
 freeipa.spec.in | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index bc47df4c916bd8f091fc2f70330d95bd116ad187..bab0b87b57370715d8346d33099a19060738292d 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -493,6 +493,10 @@ Requires: python-setuptools
 Requires: python-six
 Requires: python-jwcrypto
 Requires: python-cffi
+Requires: python-ldap >= 2.4.15
+Requires: python-requests
+Requires: python-custodia
+Requires: python-dns >= 1.11.1
 
 Conflicts: %{alt_name}-python < %{version}
 
@@ -537,6 +541,10 @@ Requires: python3-setuptools
 Requires: python3-six
 Requires: python3-jwcrypto
 Requires: python3-cffi
+Requires: python3-pyldap >= 2.4.15
+Requires: python3-custodia
+Requires: python3-requests
+Requires: python3-dns >= 1.11.1
 
 %description -n python3-ipalib
 IPA is an integrated solution to provide centrally managed Identity (users,
-- 
2.5.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to