On 02/23/2016 03:20 PM, Lenka Doudova wrote:
Hi,

attached is patch providing missing test coverage for ID views in webUI.

Lenka


Hi,

Thank you for your patch. I have small one comment: The delete_associtaion() function duplicates code, it would be good to create auxiliary function and move that code there. NACK.

--
Pavel^3 Vomacka
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to