On 8.3.2016 17:45, Martin Babinsky wrote:
On 03/08/2016 05:35 PM, Jan Cholasta wrote:
On 8.3.2016 16:21, Martin Babinsky wrote:
1) Instead of checking for utf-8 in particular, I would prefer a more
qr = qrcode.QRCode()
# it is not printable
# it is printable
Now you mean the check in the _check_qrcode_capability() or the
_print_qrcode() method itself?
_check_qrcode_capability() of course.
2) There is no os.isatty() check to see if stdout is actually a tty.
This check is performed inside both print_ascii() and print_tty()
methods of QRCode object, but you probably mean that I should put the
check also into _check_qrcode_capability() method, right?
Yes. If stdout is not a tty, we should at least not tty=True in
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code