On 02/22/2016 05:34 PM, Pavel Vomacka wrote:


On 02/18/2016 06:21 PM, Petr Vobornik wrote:
On 02/03/2016 03:37 PM, Pavel Vomacka wrote:
Hello,

I'm sending a patch for review. This patch adds pan and zoom
functionality to the topology graph. The page remembers old position and
size of the graph. So, it keeps these settings after refreshing the
page.

The patch is in atachement.

Pavel Vomacka



1. if node.fixed should be number then, we can store number in local
storage as well(only as string, e.g. num + '') instead of 'true' so
that we make the logic more straightforward/consistent.

Fixed.
2. following lines are too long: .attr("transform", "translate(" +
d3.event.translate + ")scale(" + d3.event.scale + ")");

.attr('transform', 'translate(' + trans.translate + ')scale(' +
trans.scale + ')');

These two and one more line are now split into more lines which are
short enough.
3. 'svg_' prefix for translate and scale keys is too generic, would
use e.g. topo_graph

'svg_' prefix is changed to the 'graph' prefix.

There is also change in using 'this' and 'that' variables. Instead of
declaring 'that' variable there is used the bind() method.


ACK

Pushed to:
master: 18a4053a687ac51c43cb594debe02409537647cf
ipa-4-3: b59e49feb9c3b820256a006f1202e4abd82ed691
--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to