On 11.03.2016 10:12, Pavel Vomacka wrote:


On 03/08/2016 02:34 PM, Lenka Doudova wrote:


On 03/08/2016 12:43 PM, Pavel Vomacka wrote:


On 02/23/2016 03:20 PM, Lenka Doudova wrote:
Hi,

attached is patch providing missing test coverage for ID views in webUI.

Lenka


Hi,

Thank you for your patch. I have small one comment: The delete_associtaion() function duplicates code, it would be good to create auxiliary function and move that code there. NACK.

--
Pavel^3 Vomacka


Hi,

thanks for review, fixed patch attached.

Lenka


Thank you, ACK.

--
Pavel^3 Vomacka


Pushed to master: 904db149e9f99b9a318441bc50972a8336a5b4c0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to