On 18.3.2016 05:16, Timo Aaltonen wrote:
07.01.2016, 10:50, Jan Cholasta kirjoitti:
Hi,

the attached patch ports the _ipap11helper module to python-cffi.

Combined with my patch 536 [1], this makes ipapython architecture
independent.

don't know why it works for you, but ipa-ods-exporter and 
ipa-dnskeysync-replica both still try to import _ipap11helper, which fails:

maalis 18 05:45:46 trusty.tyrell ipa-ods-exporter[8788]: Traceback (most recent 
call last):
maalis 18 05:45:46 trusty.tyrell ipa-ods-exporter[8788]:   File 
"/usr/lib/ipa/ipa-ods-exporter", line 4
maalis 18 05:45:46 trusty.tyrell ipa-ods-exporter[8788]:     import 
_ipap11helper
maalis 18 05:45:46 trusty.tyrell ipa-ods-exporter[8788]: ImportError: No module 
named _ipap11helper
maalis 18 05:45:46 trusty.tyrell systemd[1]: ipa-ods-exporter.service: Main 
process exited, code=exited
maalis 18 05:45:46 trusty.tyrell systemd[1]: ipa-ods-exporter.service: Unit 
entered failed state.
maalis 18 05:45:46 trusty.tyrell systemd[1]: ipa-ods-exporter.service: Failed 
with result 'exit-code'.
maalis 18 05:46:47 trusty.tyrell systemd[1]: ipa-ods-exporter.service: Service 
hold-off time over, sche
maalis 18 05:46:47 trusty.tyrell systemd[1]: Stopped IPA OpenDNSSEC Signer 
replacement.

dropping the import makes it work again here.. this is with fairly current 
ipa-4-3 branch.

Patch attached.

Pylint does not detect this obvious error for some reason.

--
Jan Cholasta
From eb67b237542cf2c57599f48b5d6375514f75f3e5 Mon Sep 17 00:00:00 2001
From: Jan Cholasta <jchol...@redhat.com>
Date: Fri, 18 Mar 2016 08:11:29 +0100
Subject: [PATCH] daemons: remove unused erroneous _ipap11helper import

https://fedorahosted.org/freeipa/ticket/5596
---
 daemons/dnssec/ipa-dnskeysync-replica | 1 -
 daemons/dnssec/ipa-ods-exporter       | 1 -
 2 files changed, 2 deletions(-)

diff --git a/daemons/dnssec/ipa-dnskeysync-replica b/daemons/dnssec/ipa-dnskeysync-replica
index b6f4be5..e913b8f 100755
--- a/daemons/dnssec/ipa-dnskeysync-replica
+++ b/daemons/dnssec/ipa-dnskeysync-replica
@@ -33,7 +33,6 @@ from ipaplatform.paths import paths
 from ipapython.dnssec.abshsm import sync_pkcs11_metadata, ldap2p11helper_api_params, wrappingmech_name2id
 from ipapython.dnssec.ldapkeydb import LdapKeyDB
 from ipapython.dnssec.localhsm import LocalHSM
-import _ipap11helper
 
 DAEMONNAME = 'ipa-dnskeysyncd'
 PRINCIPAL = None  # not initialized yet
diff --git a/daemons/dnssec/ipa-ods-exporter b/daemons/dnssec/ipa-ods-exporter
index e588a99..1367218 100755
--- a/daemons/dnssec/ipa-ods-exporter
+++ b/daemons/dnssec/ipa-ods-exporter
@@ -44,7 +44,6 @@ from ipaplatform.paths import paths
 from ipapython.dnssec.abshsm import sync_pkcs11_metadata, wrappingmech_name2id
 from ipapython.dnssec.ldapkeydb import LdapKeyDB
 from ipapython.dnssec.localhsm import LocalHSM
-import _ipap11helper
 
 DAEMONNAME = 'ipa-ods-exporter'
 PRINCIPAL = None  # not initialized yet
-- 
2.5.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to