On 20.3.2016 21:56, Martin Basti wrote:
> Patches attached.

I do not really like
because it replaces most of

try: ... except:


try: ... except Exception:

which AFAIK does not add any value. It would be better to replace Exception
with more specific exception so the code raises an error instead of continuing
when something really unexpected happens.

Other patches look sensible to me.

Petr^2 Spacek

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to