On 15.04.2016 15:03, Petr Vobornik wrote:
On 04/15/2016 01:25 PM, Martin Basti wrote:

On 15.04.2016 13:18, David Kupka wrote:
On 14/04/16 17:47, Martin Basti wrote:
https://fedorahosted.org/freeipa/ticket/5774

Patch attached.


Hi,
works for me, ACK.

FYI: While trying this I've hit related issue
(https://fedorahosted.org/freeipa/ticket/5822) but I believe the
impact is minimal.
Pushed to master: 93871bf017e1bc5f2c176aa3419278d49fcc003b

API.txt and version was not updated:

-option: Int('ipamaxusernamelength', attribute=True, autofill=False,
cli_name='maxusername', minvalue=1, multivalue=False, required=False)
+option: Int('ipamaxusernamelength', attribute=True, autofill=False,
cli_name='maxusername', maxvalue=255, minvalue=1, multivalue=False,
required=False)

Sorry.

Patch attached.
From d43973ac14ad635d5dada746162e152db7f6caa2 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Fri, 15 Apr 2016 15:38:53 +0200
Subject: [PATCH] Increase API version for 'ipamaxusernamelength' attribute
 change

https://fedorahosted.org/freeipa/ticket/5774
---
 API.txt | 2 +-
 VERSION | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/API.txt b/API.txt
index 5b75413f930d0e9caaffc68023bed8106d786653..3598b08198cae536754259f7463669052efa3f86 100644
--- a/API.txt
+++ b/API.txt
@@ -774,7 +774,7 @@ option: Str('ipagroupobjectclasses', attribute=True, autofill=False, cli_name='g
 option: IA5Str('ipagroupsearchfields', attribute=True, autofill=False, cli_name='groupsearch', multivalue=False, required=False)
 option: IA5Str('ipahomesrootdir', attribute=True, autofill=False, cli_name='homedirectory', multivalue=False, required=False)
 option: StrEnum('ipakrbauthzdata', attribute=True, autofill=False, cli_name='pac_type', csv=True, multivalue=True, required=False, values=(u'MS-PAC', u'PAD', u'nfs:NONE'))
-option: Int('ipamaxusernamelength', attribute=True, autofill=False, cli_name='maxusername', minvalue=1, multivalue=False, required=False)
+option: Int('ipamaxusernamelength', attribute=True, autofill=False, cli_name='maxusername', maxvalue=255, minvalue=1, multivalue=False, required=False)
 option: Bool('ipamigrationenabled', attribute=True, autofill=False, cli_name='enable_migration', multivalue=False, required=False)
 option: Int('ipapwdexpadvnotify', attribute=True, autofill=False, cli_name='pwdexpnotify', minvalue=0, multivalue=False, required=False)
 option: Int('ipasearchrecordslimit', attribute=True, autofill=False, cli_name='searchrecordslimit', minvalue=-1, multivalue=False, required=False)
diff --git a/VERSION b/VERSION
index 825aace1b8c78486b37ac1809b664ca18f97523b..aedebd185821d42fa48608f4c5fdf9ff510ace3f 100644
--- a/VERSION
+++ b/VERSION
@@ -90,5 +90,5 @@ IPA_DATA_VERSION=20100614120000
 #                                                      #
 ########################################################
 IPA_API_VERSION_MAJOR=2
-IPA_API_VERSION_MINOR=164
-# Last change: simo - add optional string to disable preauth for SPNs
+IPA_API_VERSION_MINOR=165
+# Last change: mbasti - limit ipamaxusernamelength value to 255
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to