On 22.04.2016 14:35, Petr Spacek wrote:
On 12.4.2016 17:26, Martin Basti wrote:

On 04.04.2016 17:37, Petr Spacek wrote:
On 31.3.2016 13:45, Martin Basti wrote:
On 21.03.2016 16:51, Petr Spacek wrote:
On 10.3.2016 22:17, Lukas Slebodnik wrote:
On (10/03/16 22:14), Petr Spacek wrote:
Hello,

I forgot to send a patches before I leave, so here it is:

Auto-detect default value for --forward-policy option in installers

See
https://fedorahosted.org/freeipa/ticket/5710
commit messages, and design page
https://fedorahosted.org/bind-dyndb-ldap/wiki/BIND9/Design/AutomaticEmptyZones




I did not have time to test it thoroughly but it LGTM :-D

Please note that this is first part, it does not solve upgrade (yet) and
warnings in forwardzone-* interface.

This can be solved in another patch set, this can be pushed if it passes
review.

ENOPATH
LOL, here it is.



   * Remove function ipapython.ipautil.host_exists() *
ACK


* Extend installers with --forward-policy option *
1)
There is no --forward-policy option in ipa-dns-install


* Move automatic empty zone list into ipapython.dnsutil and make it reusable *
ACK


* Add assert_absolute_dnsname() helper to ipapython.dnsutil *
ACK


* Move function is_auto_empty_zone() into ipapython.dnsutil *
ACK


* Use shared sanity check and tests ipapython.dnsutil.is_auto_empty_zone() *
ACK

* Add function ipapython.dnsutil.inside_auto_empty_zone() *
ACK

* Auto-detect default value for --forward-policy option in installers *
LGTM, but ipa-dns-install is missing option --forward-policy

# ipa-dns-install
...
Unexpected error - see /var/log/ipaserver-install.log for details:
AttributeError: Values instance has no attribute 'forward_policy'


Summary: 6 ACKs, 1 LGTM, 1 NACK => NACK
Thank you very much for review.

Here is my second attempt :-)

Hello,
code works as expected, but it is quite inconsistent with current behavior

ipa-server-install --forward-policy should raise error without --setup-dns 
option

Like here:
[root@vm-058-134 ~]# ipa-server-install --forwarder=10.2.3.4
Usage: ipa-server-install [options]

ipa-server-install: error: You cannot specify a --forwarder option without the
--setup-dns option
ipa.ipapython.install.cli.install_tool(Server): ERROR    The
ipa-server-install command failed. See /var/log/ipaserver-install.log for more
information

Martin
Fixed patches are attached. Thank you for your time!

almost ack but patches need rebase on  ipa-4-3

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to