On 05/03/2016 03:02 PM, Petr Spacek wrote:
> On 2.5.2016 18:02, Martin Basti wrote:
>>
>>
>> On 29.04.2016 19:46, Petr Viktorin wrote:
>>> Hello,
>>> These patches concentrate on tests, and code that was added/changed
>>> since I last looked at the FreeIPA project.
>>>
>>> With these patches, I'm back to getting the same errors under py2 and
>>> py3 when in test_xmlrpc.
>>>
>>>
>>>
>>>
>> Patch 777:
>> Could you fix all relative imports and enable check in pylint for that?
>> (Remove relative-import from pylintrc), IMO there is just one extra relative
>> import in custodia module.

Would it be OK if I do that in a separate patch, in the next batch? This
one is fixing the tests.
(I have the change in my worktree, so I won't forget when I next sit
down to work on IPA.)

>> Do you plan to use in py2 ?
>> from__future__importabsolute_import

I think that's unnecessary boilerplate; the errors this catches are
easily found by other means.
And it doesn't guard against someone forgetting the __future__ import
itself in a new file. The pylint check will be much better.

>>
>> Patch 778:
>> LGTM
>>
>> Patch 779
>> LGTM
>>
>> Patch 780
>> LGTM
>>
>> Patch 781
>> LGTM
>>
>> Patch 782
>> Not sure, I will review it longer
>>
>> Patch 783
>> LGTM
>>
>> Patch 784
>> LGTM
>>
>> Patch 785
>> LGTM
>>
>> I will test it with both py2 and py3 to convert LGTM to ACK :)
> 
> Functional ACK, I did not find any breakage (when combined with other Py3
> patches).
> 


-- 
Petr Viktorin

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to