Hi everyone

this is a second update that take into account review feedback.

In case the proposal fix is K what are the next step to commit this change. I'm not sure to really understand the process. Thanks and regards

Pat

>From 0a2b0da4a1f2c517fae392ae3314796c0ebeee9a Mon Sep 17 00:00:00 2001
From: Patrice Duc-Jacquet <patdu...@gmail.com>
Date: Wed, 4 May 2016 09:25:57 +0200
Subject: [PATCH] Add more information regarding where to find revocation
 reason in "ipa cert_revoke -h" and "ipa cert_find -h". According to review
 feedback, I changed the help message as follow

$ ipa cert_revoke -h
Usage: ipa [global-options] cert-revoke SERIAL-NUMBER [options]

Revoke a certificate.
Options:
  -h, --help            show this help message and exit
  --revocation-reason=INT
                        Reason for revoking the certificate (0-10). Type "ipa
                        help cert" for revocation reason details.

https://fedorahosted.org/freeipa/ticket/5819
---
 ipalib/plugins/cert.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ipalib/plugins/cert.py b/ipalib/plugins/cert.py
index 4dc51c2bf81546766193c0d28f0dc47239a3910c..820069cb06407565c3593201dfe49452e6588a2e 100644
--- a/ipalib/plugins/cert.py
+++ b/ipalib/plugins/cert.py
@@ -665,7 +665,7 @@ class cert_revoke(VirtualCommand):
     takes_options = (
         Int('revocation_reason',
             label=_('Reason'),
-            doc=_('Reason for revoking the certificate (0-10). See RFC 5280 (paragraph 5.3.1) for reason details'),
+            doc=_('Reason for revoking the certificate (0-10). Type "ipa help cert" for revocation reason details.'),
             minvalue=0,
             maxvalue=10,
             default=0,
@@ -733,7 +733,7 @@ class cert_find(Command):
         ),
         Int('revocation_reason?',
             label=_('Reason'),
-            doc=_('Reason for revoking the certificate (0-10). See RFC 5280 (paragraph 5.3.1) for reason details'),
+            doc=_('Reason for revoking the certificate (0-10). Type "ipa help cert" for revocation reason details.'),
             minvalue=0,
             maxvalue=10,
             autofill=False,
-- 
2.5.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to