On 10.05.2016 13:59, Abhijeet Kasurde wrote:
Hi All,

Please find the patch for review.

Thanks,
Abhijeet Kasurde

On 05/10/2016 01:13 PM, Martin Basti wrote:



On 09.05.2016 07:26, Abhijeet Kasurde wrote:
Hi all,

Please review the patch.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1333755

Thanks,
Abhijeet Kasurde



Hello,

+            self.raise_certificate_operation_error('parse',
+                                                   detail=e.msg)

Please use detail=str(e), e.msg is deprecated

Martin^2




For future:
* patches should contain trac ticket instead of a BZ link (I amended patch with ticket) * BZ was marked as wontfix, but because patch was trivial I reopened BZ and cloned ticket to trac. Please don't do any wontfix tickets/bz, any patches for these will be rejected

ACK

master:
* 2df25cb359723dd72077c60a12bc037d5c77f931 Added exception handling for mal-formatted XML Parsing

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to