On 13.05.2016 15:05, Peter Lacko wrote:
Desciption added back, header changed to original.
Peter
----- Original Message -----
From: "Martin Basti" <[email protected]>
To: "Peter Lacko" <[email protected]>
Cc: [email protected]
Sent: Friday, May 13, 2016 2:02:00 PM
Subject: Re: [Freeipa-devel] [TESTS][PATCH] Ping module tests in a
non-declarative way
On 13.05.2016 13:59, Peter Lacko wrote:
Hi,
Thanks again, will remember that. I also changed header to short one.
Peter
Whyyy?
----- Original Message -----
From: "Martin Basti" <[email protected]>
To: "Peter Lacko" <[email protected]>, [email protected]
Sent: Tuesday, May 10, 2016 12:23:13 PM
Subject: Re: [Freeipa-devel] [TESTS][PATCH] Ping module tests in a
non-declarative way
On 28.04.2016 16:09, Martin Basti wrote:
On 08.04.2016 10:32, Peter Lacko wrote:
Hello,
I have a few comments:
1)
Please set up your git name and email correctly (consistently for all
patches)
this is not right From: root<[email protected]>
2)
-# Copyright (C) 2012 Red Hat
+# Copyright (C) 2016 Red Hat
leave there both years please
+# Copyright (C) 2012, 2016 Red Hat
3)
Please put the patch number to the email subject, it is easier to find correct
patch for us
Otherwise LGTM and works for me.
Martin^2
Sorry I didn't noticed earlier, but your patch doesn't work under python3
from xmlrpc_test import XMLRPC_test, raises_exact
E ImportError: No module named 'xmlrpc_test'
You must use absolute import, not relative in py3
Martin^2
Sorry, NACK
************* Module ipatests.test_xmlrpc.test_ping_plugin
ipatests/test_xmlrpc/test_ping_plugin.py:29: [E0611(no-name-in-module),
] No name 'test_xmplrpc' in module 'ipatests')
did you mean 'test_xmlrpc'?
Martin^2
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
