NACK, see my comments below
+ # following upgrade steps require running CA
This is a nitpicky nitpick but could you please change this comment for
# the following ...
Took me a while to understand what you were trying to say here.
+ if ca_running and not ca.is_running():
+ ca.stop('pki-tomcat')
+ elif not ca_running and ca.is_running():
+ ca.start('pki-tomcat')
+
You should swap ca.stop and ca.start here, you're stopping the service
when it's stopped and starting it when it's already running.
On 05/12/2016 04:34 PM, Martin Basti wrote:
Patch attached.
https://fedorahosted.org/freeipa/ticket/5868
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
