On 19.5.2016 14:47, Martin Basti wrote:
> On 19.05.2016 14:26, Petr Spacek wrote:
>> Hello,
>>
>> pylint: replace Refactor category with individual check names
>>
>> This eases enabling/disabling individual tests like cyclic-import.
>>
> 
> I like this patch but, NACK
> 
> ....<snip>.....
> ************* Module ipalib.config
> ipalib/config.py:260: [R0204(redefined-variable-type), Env.__setitem__]
> Redefinition of value type from int to ipapython.dn.DN)
> ipalib/config.py:458: [R0102(simplifiable-if-statement), Env._bootstrap] The
> if statement can be replaced with 'var = bool(test)')
> ************* Module ipalib.messages
> ipalib/messages.py:90: [R0204(redefined-variable-type),
> process_message_arguments] Redefinition of obj.strerror type from unicode to 
> str)
> ************* Module ipalib.plugable
> ipalib/plugable.py:569: [R0204(redefined-variable-type), API.import_plugins]
> Redefinition of modules type from generator to list)
> ************* Module ipalib.rpc
> ipalib/rpc.py:609: [R0101(too-many-nested-blocks),
> KerbTransport.single_request] Too many nested blocks (6/5))
> ipalib/rpc.py:753: [R0204(redefined-variable-type), RPCClient.get_url_list]
> Redefinition of answers type from dns.resolver.Answer to list)
> ....<snip>....
> 
> 
> tested with pylint-1.5.5-1.fc24.noarch

Here it is.

-- 
Petr^2 Spacek
From a1679b9b7256db91dc47f41c1eed07e91224a836 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Thu, 19 May 2016 14:25:31 +0200
Subject: [PATCH] pylint: replace Refactor category with individual check names

This eases enabling/disabling individual tests like cyclic-import.
---
 pylintrc | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/pylintrc b/pylintrc
index 7ef441844ef0051ddbdec348236e6fdc308f79b6..bb9c636867e1a89afa689cb4bbb901411cd3cf7a 100644
--- a/pylintrc
+++ b/pylintrc
@@ -16,8 +16,25 @@ enable=
     python3
 
 disable=
-    R,
     I,
+    cyclic-import,
+    duplicate-code,
+    import-error,
+    interface-not-implemented,
+    no-self-use,
+    redefined-variable-type,
+    simplifiable-if-statement,
+    too-few-public-methods,
+    too-many-ancestors,
+    too-many-arguments,
+    too-many-boolean-expressions,
+    too-many-branches,
+    too-many-instance-attributes,
+    too-many-locals,
+    too-many-nested-blocks,
+    too-many-public-methods,
+    too-many-return-statements,
+    too-many-statements,
     import-error,
     abstract-method,
     anomalous-backslash-in-string,
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to