On 20.5.2016 13:21, Abhijeet Kasurde wrote:
> Hi All,
> 
> Please find the patch for review.
> 
> On 05/09/2016 01:28 PM, Petr Spacek wrote:
>> On 6.5.2016 07:33, Abhijeet Kasurde wrote:
>>> Please review this patch.
>> Good catch!
>>
>> In general, I believe that man page should explain what domain level means
>> (probably with an example of levels 0 and 1) so the user can actually use the
>> man page to find out what value is needed for his purposes.
>>
>> Considering this, I have to NACK this patch. Please elaborate.
>>
>> Thank you!
>>
> 
> -- 
> Thanks,
> Abhijeet Kasurde
> 
> IRC: akasurde
> http://akasurde.github.io
> 
> 
> freeipa-akasurde-0013-1-Updated-ipa-server-install-man-page-for-domain-level-ipa-4-3.patch
> 
> 
> From e32e9a1b5b1d666d53c575a27beb8dadd09e26cc Mon Sep 17 00:00:00 2001
> From: Abhijeet Kasurde <akasu...@redhat.com>
> Date: Fri, 20 May 2016 16:45:40 +0530
> Subject: [PATCH] Updated ipa-server-install man page for domain-level
>  attribute
> 
> Fixes: https://fedorahosted.org/freeipa/ticket/5708
> 
> Signed-off-by: Abhijeet Kasurde <akasu...@redhat.com>
> ---
>  install/tools/man/ipa-server-install.1 | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/install/tools/man/ipa-server-install.1 
> b/install/tools/man/ipa-server-install.1
> index 
> 55b49449e3c44aebfeefe5cb71d73e9abf07c5b2..7638726c306ed64706c33564f1ca175197e7a7bf
>  100644
> --- a/install/tools/man/ipa-server-install.1
> +++ b/install/tools/man/ipa-server-install.1
> @@ -1,5 +1,5 @@
>  .\" A man page for ipa-server-install
> -.\" Copyright (C) 2008 Red Hat, Inc.
> +.\" Copyright (C) 2008-2016 Red Hat, Inc.
>  .\"
>  .\" This program is free software; you can redistribute it and/or modify
>  .\" it under the terms of the GNU General Public License as published by
> @@ -16,7 +16,7 @@
>  .\"
>  .\" Author: Rob Crittenden <rcrit...@redhat.com>
>  .\"
> -.TH "ipa-server-install" "1" "Jun 28 2012" "FreeIPA" "FreeIPA Manual Pages"
> +.TH "ipa-server-install" "1" "May 20 2016" "FreeIPA" "FreeIPA Manual Pages"
>  .SH "NAME"
>  ipa\-server\-install \- Configure an IPA server
>  .SH "SYNOPSIS"
> @@ -84,6 +84,9 @@ An unattended installation that will never prompt for user 
> input
>  .TP
>  \fB\-\-dirsrv\-config\-file\fR
>  The path to LDIF file that will be used to modify configuration of dse.ldif 
> during installation of the directory server instance
> +.TP
> +\fB\-\-domain\-level\fR
> +Specifies IPA domain level value. Domain level indicates that server is 
> capable of doing certain operations. Domain level 1 means that it supports 
> replica promotion and topology management. Old IPA servers and IPA servers 
> upgraded to 4.3 in existing environments have domain level 0.
>  
>  .SS "CERTIFICATE SYSTEM OPTIONS"
>  .TP
> -- 2.4.11
> 

Thanks but NACK.

Domain level is not about one server. It defines that all servers in one IPA
topology behave in some particular way.

-- 
Petr^2 Spacek

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to