On 04/28/2016 05:15 PM, Petr Spacek wrote:
On 28.4.2016 14:52, Abhijeet Kasurde wrote:
Hi Petr,

On 04/25/2016 08:28 PM, Petr Spacek wrote:

ipa-nis-manage: add status option


Can you reword the error message here as well ?

     if len(args) != 1:
         sys.exit("You must specify one action, either enable or disable")

Abhijeet Kasurde

Good catch!

Hi Petr,

please use upstream ticket provided by Petr Vobornik[1] in the commit message.

Also I would rewrite

"""+ elif args[0] != "enable" and args[0] != "disable" and args[0] != "status":


in a more pythonic way:

"    elif args[0] not in {"enable", "disable", "status"}:"

Otherwise the patch works as expected.

[1] https://fedorahosted.org/freeipa/ticket/5856

Martin^3 Babinsky

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to