On 19.05.2016 16:46, Ganna Kaihorodova wrote:
Hello!

Everything is ok, so ack

Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer
Pushed to master: d71de186cc4d942b2a1bb7fcd9677bfcedd86b26




----- Original Message -----
From: "Lenka Doudova" <ldoud...@redhat.com>
To: "Ganna Kaihorodova" <gkaih...@redhat.com>
Cc: freeipa-devel@redhat.com
Sent: Thursday, May 19, 2016 12:42:34 PM
Subject: Re: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length higher 
than 255 cannot be set



On 05/18/2016 01:51 PM, Ganna Kaihorodova wrote:
----- Original Message -----
From: "Lenka Doudova" <ldoud...@redhat.com>
To: "Ganna Kaihorodova" <gkaih...@redhat.com>
Sent: Wednesday, May 18, 2016 10:37:49 AM
Subject: Fwd: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length 
higher than 255 cannot be set



-------- Forwarded Message --------
Subject:        [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length
higher than 255 cannot be set
Date:   Fri, 13 May 2016 13:08:29 +0200
From:   Lenka Doudova <ldoud...@redhat.com>
To:     freeipa-devel <freeipa-devel@redhat.com>



Patch attached.

Lenka


Hello,

sorry, nack, because:
1. Tests doesn't clean up after performing. Max user name isn't returned 
original value.

2. pep8 errors:
./ipatests/test_xmlrpc/test_config_plugin.py:167:21: E126 continuation line 
over-indented for hanging indent
./ipatests/test_xmlrpc/test_config_plugin.py:170:17: E121 continuation line 
under-indented for hanging indent


Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer
Hi,

thanks for review, fixed patch attached.

Lenka


--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to