On 06/08/2016 03:32 PM, Pavel Vomacka wrote:
> 
> 
> On 06/08/2016 02:20 PM, Petr Vobornik wrote:
>> On 06/06/2016 04:17 PM, Pavel Vomacka wrote:
>>> Hello,
>>>
>>> please review attached patch.
>>>
>>> Ticket: https://fedorahosted.org/freeipa/ticket/5931
>>>
>> Also tables for host groups are needed.
>>
>> + the same UI should be also on host page.
> Added, please see attached patch.

1.hostgroups cannot be removed from "allow to read" tables.

This should fix it.

-  name: 'ipaallowedtoperform_read_keys_hosts_group',
+  name: 'ipaallowedtoperform_read_keys_hostgroup',

-  name: 'ipaallowedtoperform_read_keys_hosts_group',
+  name: 'ipaallowedtoperform_read_keys_hostgroup',

Patch with the change attached. ACK if you ACK it :)
-- 
Petr Vobornik
From 8ed91c9aeab243c4e42dce566ff5bdd1dd63e849 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka <pvoma...@redhat.com>
Date: Mon, 6 Jun 2016 12:59:24 +0200
Subject: [PATCH] Add lists of hosts allowed to create or retrieve keytabs

Attributes tables are added on host and service pages.

https://fedorahosted.org/freeipa/ticket/5931
---
 install/ui/src/freeipa/host.js    | 64 +++++++++++++++++++++++++++++++++++++++
 install/ui/src/freeipa/service.js | 64 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 128 insertions(+)

diff --git a/install/ui/src/freeipa/host.js b/install/ui/src/freeipa/host.js
index 817e62efca7dca9745c71ee4d4d4823f885a8fab..80e3db65844759cb195c56fe0b48a95bba78bd00 100644
--- a/install/ui/src/freeipa/host.js
+++ b/install/ui/src/freeipa/host.js
@@ -187,6 +187,38 @@ return {
                                     link: true
                                 }
                             ]
+                        },
+                        {
+                            $type: 'association_table',
+                            id: 'service_ipaallowedtoperform_read_keys_host',
+                            name: 'ipaallowedtoperform_read_keys_host',
+                            add_method: 'allow_retrieve_keytab',
+                            remove_method: 'disallow_retrieve_keytab',
+                            add_title: '@i18n:keytab.add_retrive',
+                            remove_title: '@i18n:keytab.remove_retrieve',
+                            columns: [
+                                {
+                                    name: 'ipaallowedtoperform_read_keys_host',
+                                    label: '@mo:host.label_singular',
+                                    link: true
+                                }
+                            ]
+                        },
+                        {
+                            $type: 'association_table',
+                            id: 'service_ipaallowedtoperform_read_keys_hostgroup',
+                            name: 'ipaallowedtoperform_read_keys_hostgroup',
+                            add_method: 'allow_retrieve_keytab',
+                            remove_method: 'disallow_retrieve_keytab',
+                            add_title: '@i18n:keytab.add_retrive',
+                            remove_title: '@i18n:keytab.remove_retrieve',
+                            columns: [
+                                {
+                                    name: 'ipaallowedtoperform_read_keys_hostgroup',
+                                    label: '@mo:hostgroup.label_singular',
+                                    link: true
+                                }
+                            ]
                         }
                     ]
                 },
@@ -226,6 +258,38 @@ return {
                                     link: true
                                 }
                             ]
+                        },
+                        {
+                            $type: 'association_table',
+                            id: 'service_ipaallowedtoperform_write_keys_host',
+                            name: 'ipaallowedtoperform_write_keys_host',
+                            add_method: 'allow_create_keytab',
+                            remove_method: 'disallow_create_keytab',
+                            add_title: '@i18n:keytab.add_create',
+                            remove_title: '@i18n:keytab.remove_create',
+                            columns: [
+                                {
+                                    name: 'ipaallowedtoperform_write_keys_host',
+                                    label: '@mo:host.label_singular',
+                                    link: true
+                                }
+                            ]
+                        },
+                        {
+                            $type: 'association_table',
+                            id: 'service_ipaallowedtoperform_write_keys_hostgroup',
+                            name: 'ipaallowedtoperform_write_keys_hostgroup',
+                            add_method: 'allow_create_keytab',
+                            remove_method: 'disallow_create_keytab',
+                            add_title: '@i18n:keytab.add_create',
+                            remove_title: '@i18n:keytab.remove_create',
+                            columns: [
+                                {
+                                    name: 'ipaallowedtoperform_write_keys_hostgroup',
+                                    label: '@mo:hostgroup.label_singular',
+                                    link: true
+                                }
+                            ]
                         }
                     ]
                 }
diff --git a/install/ui/src/freeipa/service.js b/install/ui/src/freeipa/service.js
index 73732dd48e833668cdcb66e9057b5ae8e4f8a330..6f8e4efbd7f07574e924cbdeac970b70eb0a9b0e 100644
--- a/install/ui/src/freeipa/service.js
+++ b/install/ui/src/freeipa/service.js
@@ -201,6 +201,38 @@ return {
                                     link: true
                                 }
                             ]
+                        },
+                        {
+                            $type: 'association_table',
+                            id: 'service_ipaallowedtoperform_read_keys_host',
+                            name: 'ipaallowedtoperform_read_keys_host',
+                            add_method: 'allow_retrieve_keytab',
+                            remove_method: 'disallow_retrieve_keytab',
+                            add_title: '@i18n:keytab.add_retrive',
+                            remove_title: '@i18n:keytab.remove_retrieve',
+                            columns: [
+                                {
+                                    name: 'ipaallowedtoperform_read_keys_host',
+                                    label: '@mo:host.label_singular',
+                                    link: true
+                                }
+                            ]
+                        },
+                        {
+                            $type: 'association_table',
+                            id: 'service_ipaallowedtoperform_read_keys_hostgroup',
+                            name: 'ipaallowedtoperform_read_keys_hostgroup',
+                            add_method: 'allow_retrieve_keytab',
+                            remove_method: 'disallow_retrieve_keytab',
+                            add_title: '@i18n:keytab.add_retrive',
+                            remove_title: '@i18n:keytab.remove_retrieve',
+                            columns: [
+                                {
+                                    name: 'ipaallowedtoperform_read_keys_hostgroup',
+                                    label: '@mo:hostgroup.label_singular',
+                                    link: true
+                                }
+                            ]
                         }
                     ]
                 },
@@ -240,6 +272,38 @@ return {
                                     link: true
                                 }
                             ]
+                        },
+                        {
+                            $type: 'association_table',
+                            id: 'service_ipaallowedtoperform_write_keys_host',
+                            name: 'ipaallowedtoperform_write_keys_host',
+                            add_method: 'allow_create_keytab',
+                            remove_method: 'disallow_create_keytab',
+                            add_title: '@i18n:keytab.add_create',
+                            remove_title: '@i18n:keytab.remove_create',
+                            columns: [
+                                {
+                                    name: 'ipaallowedtoperform_write_keys_host',
+                                    label: '@mo:host.label_singular',
+                                    link: true
+                                }
+                            ]
+                        },
+                        {
+                            $type: 'association_table',
+                            id: 'service_ipaallowedtoperform_write_keys_hostgroup',
+                            name: 'ipaallowedtoperform_write_keys_hostgroup',
+                            add_method: 'allow_create_keytab',
+                            remove_method: 'disallow_create_keytab',
+                            add_title: '@i18n:keytab.add_create',
+                            remove_title: '@i18n:keytab.remove_create',
+                            columns: [
+                                {
+                                    name: 'ipaallowedtoperform_write_keys_hostgroup',
+                                    label: '@mo:hostgroup.label_singular',
+                                    link: true
+                                }
+                            ]
                         }
                     ]
                 }
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to