This regression was introduce by https://fedorahosted.org/freeipa/ticket/5710 thus this should go to 4.3.2 as well


Patch attached.

From b47bd75ae4126a15a569fc45d2b3a2947ac25fa8 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Thu, 9 Jun 2016 14:09:45 +0200
Subject: [PATCH] Fix resolve_rrsets: RRSet is not hasbale

We cannot use set() with RRSet objects, because RRSet object is not
hasable. A set was replaced by list.

https://fedorahosted.org/freeipa/ticket/5710
---
 ipapython/dnsutil.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ipapython/dnsutil.py b/ipapython/dnsutil.py
index f68d3c4105b13e5a8b1338da194612d51aae5331..6aa0e0772d2a3339a18e06c33419083a58e237e4 100644
--- a/ipapython/dnsutil.py
+++ b/ipapython/dnsutil.py
@@ -299,14 +299,14 @@ def resolve_rrsets(fqdn, rdtypes):
         fqdn = DNSName(fqdn)
 
     fqdn = fqdn.make_absolute()
-    rrsets = set()
+    rrsets = []
     for rdtype in rdtypes:
         try:
             answer = dns.resolver.query(fqdn, rdtype)
             root_logger.debug('found %d %s records for %s: %s',
                               len(answer), rdtype, fqdn, ' '.join(
                                   str(rr) for rr in answer))
-            rrsets.add(answer.rrset)
+            rrsets.append(answer.rrset)
         except dns.resolver.NXDOMAIN as ex:
             root_logger.debug(ex)
             break  # no such FQDN, do not iterate
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to