On 06/10/2016 04:44 PM, thierry bordaz wrote:
I agree with you there is no path to add a host with an empty hostname.
You fix looks valid but I would prefer a log in FATAL rather in PLUGIN.
yes, of course that was my intention, copy paste :-)
but this frees the complete replica structure tconf and in the caller
tconf is set to null, so should never be used again.
Also I wonder if a reason of empty hostname could be a slapi_ch_free
on it but with the host remaining in the list.
I wonder if the two lines 852 and 853 could lead to this situation.
On 06/10/2016 12:36 PM, Ludwig Krispenz wrote:
the attached patch will prevent the crash reported in ticket #5928.
So far I do not understand how this situation can occur, there is no
reproducer yet. I do not really like this fix as it hides a probable
corrupted data structure and would prefer to find the root cause.
But please review it, so we can commit it if there is no progress on
the root cause.
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael O'Neill, Eric
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code