On 10.06.2016 23:23, Alexander Bokovoy wrote:
On Fri, 10 Jun 2016, Pavel Vomacka wrote:
On 06/09/2016 02:19 PM, Alexander Bokovoy wrote:
On Thu, 09 Jun 2016, Sumit Bose wrote:
On Thu, Jun 09, 2016 at 02:30:52PM +0300, Alexander Bokovoy wrote:
webUI changes to support external trust and showing UPN suffixes are
UPN Suffixes defined on AD side and fetched with 'ipa
They cannot be disabled individually as they come from AD side and
forest-wide, so we only show them, not allowing to modify anything.
External forest is a flag and is shown in the trust-add dialog.
The result would be visible as trust type of 'Non-transitive external
trust to a domain in another Active Directory forest'
These patches functionally depend on 0201 and 0202.
/ Alexander Bokovoy
From 4da33f5e82c83617ccfb2da7c3b70e5e66ac49d9 Mon Sep 17 00:00:00
From: Alexander Bokovoy <aboko...@redhat.com>
Date: Thu, 9 Jun 2016 12:04:05 +0300
Subject: [PATCH 7/8] webui: show UPN suffixes in trust properties
Part of https://fedorahosted.org/freeipa/ticket/5354
install/ui/src/freeipa/trust.js | 11 +++++++++++
ipaserver/plugins/internal.py | 2 ++
2 files changed, 13 insertions(+)
diff --git a/ipaserver/plugins/internal.py
index 4804f64..ea29b16 100644
@@ -747,6 +747,8 @@ class i18n_messages(Command):
"trustdirection": _("Trust direction"),
"truststatus": _("Trust status"),
"trusttype": _("Trust type"),
+ "suffixes": _("UPN suffixes"),
+ "ipantadditionalsuffixes": _("UPN suffixes"),
The AD gui calls the latter 'Alternative UPN suffixes'. Maybe we
use the same description here as well to avoid irritations?
Makes sense. I've updated the patch 0208 and also removed the string
'suffixes' which is not referenced from the UI.
thank you for patches, they look good and work well. I have only one
+ read_only: 'true'
It would be nicer to use boolean value instead of string, even if it
works correctly with string value.
And because it is really small change I edited your patch. I also
changed links in your commit messages to WebUI tickets (5904,5937).
Edited patches are attached, so ACK if you agree with these changes.
Thanks for the review.
* 5b0dbe7e5996ef95301c5fdd530f2e2a18757f04 webui: show UPN suffixes in
* d6266476fa1425dfd62cf6138b9ca7ab7b270c23 webui: support external flag
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code