On 2.6.2016 12:38, Florence Blanc-Renaud wrote:
Hi,

thanks to Jan and Fraser for the review and the suggested error message.
Please find the updated patch attached.

Flo.


On 06/02/2016 08:55 AM, Fraser Tweedale wrote:
On Thu, Jun 02, 2016 at 07:54:31AM +0200, Jan Cholasta wrote:
Hi,

On 30.5.2016 19:58, Florence Blanc-Renaud wrote:
Hi all,

this patch adds in the error message the missing certificate that caused
i/pa-server-install --external-cert-file=.../ to fail.

https://fedorahosted.org/freeipa/ticket/5792
I think someone may confuse "issuer" with the "issuer name" field in the
certificate, also IMO we should use "certificate" rather than "cert" in
error messages, so I would rather use something like "missing certificate
with subject '%s'" or maybe just "missing certificate '%s'".

Let us be as specific as possible; Honza's suggestion "missing
certificate with subject '%s'" is preferable.

Cheers,
Fraser

Thanks, ACK.

Pushed to master: 517964f746e004801e5e73d61f3f5e16102b7299

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to