On 06/20/2016 06:54 PM, Pavel Vomacka wrote: > Hello, > > please review attached patch. > > https://fedorahosted.org/freeipa/ticket/5926 >
1. I'm not sure whether to include the certificate field in the adder dialog. But if so then it is not good that it accepts different output then a cert widget. The difference is that cert widget is able to work also with "-----BEGIN CERTIFICATE-----" and "-----END CERTIFICATE-----" values. Otherwise it works good. If we decided not to fix 1. in this patch then ACK. Push should wait on the other cert patches. -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
