On 06/24/2016 12:47 PM, Stanislav Laznicka wrote: > On 06/24/2016 11:52 AM, Martin Babinsky wrote: >> On 06/24/2016 11:30 AM, Petr Vobornik wrote: >>> On 06/23/2016 05:30 PM, Stanislav Laznicka wrote: >>>> On 06/23/2016 04:38 PM, Petr Vobornik wrote: >>>>> On 06/23/2016 04:20 PM, Stanislav Laznicka wrote: >>>>>> Hello, >>>>>> >>>>>> attached are patches fixing the logic mentioned in >>>>>> https://fedorahosted.org/freeipa/ticket/5967. >>>>>> >>>>>> >>>>> If server supports the suffix can be verified in validate_nodes call >>>>> where masters are already fetched. >>>>> >>>> Thank you for the suggestion, modified patch 50 attached. >>>> >>> >>> Maybe it's just me, but the code is hard to ready. Check the attached >>> version - speeding up review process. >>> >>> I've also change the first commit message line it was too generic. >>> >>> >>> >> >> If you intend to use that internal function in other modules, please >> remove the leading underscore from its name. Otherwise pylint/IDEs may >> complain about import of private module member. >> > Thank you for the review/update. You went the other way around it which > indeed does seem much more readable. Not sure if you meant to change the > order of the patches which in order 50 -> 51 would make 50 alone not > work because of missing import but I did change the order and fixed that. > > I also included the objection from Martin in the patches and removed the > leading underscore from the imported function. >
ACK (after consultation with Standa, I've removed accidental removal of doc string). master: * 5b5258b01081aa9ad4bf83907941c1c2d8a47722 Fix topologysuffix-verify failing connections * 13328bc7518a9e536d26562a738b4591c0494b75 topo segment-add: validate that both masters support target suffix -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
