Shame, shame, shame on me. I forgot how to python when I was writing that originally.


Patch attached.

https://fedorahosted.org/freeipa/ticket/2008

From fc0ba11ce71c5585874745764dbdcda4fa615e8c Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Mon, 27 Jun 2016 08:23:59 +0200
Subject: [PATCH] DNS Locations: server-mod: fix if statement

Statement used for detection if objeclass change is needed was logically
wrong, this fixes it.

https://fedorahosted.org/freeipa/ticket/2008
---
 ipaserver/plugins/server.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipaserver/plugins/server.py b/ipaserver/plugins/server.py
index b93f72c72447a235087253741998b2edfd4780c8..c1446ae9731b2cc1eced65348442251a321d71e9 100644
--- a/ipaserver/plugins/server.py
+++ b/ipaserver/plugins/server.py
@@ -226,7 +226,7 @@ class server_mod(LDAPUpdate):
                 self.api.Object.location.handle_not_found(
                     options['ipalocation_location'])
 
-        if 'ipalocation' or 'ipaserviceweight' in entry_attrs:
+        if 'ipalocation' in entry_attrs or 'ipaserviceweight' in entry_attrs:
             server_entry = ldap.get_entry(dn, ['objectclass'])
 
             # we need to extend object with ipaLocationMember objectclass
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to