On 28.06.2016 17:41, Milan Kubík wrote:
On 06/28/2016 04:59 PM, Martin Basti wrote:


On 28.06.2016 16:46, Petr Spacek wrote:
On 23.6.2016 12:44, Martin Basti wrote:
patch attached.

https://fedorahosted.org/freeipa/ticket/5966
ACK

Pushed to master: 5693d195501611c6abe9dbdf1370b898ffa6b3c7
Pushed to ipa-4-3: 8502fe4883d33afab57cfc4cb4695ed8061daa7e

The patch doesn't pass lint on 4.3 branch.

Pylint is running, please wait ...
************* Module ipaserver.install.cainstance
ipaserver/install/cainstance.py:1632: [E0602(undefined-variable, __get_profile_config)] Undefined variable 'ipalib'
Makefile:137: recipe for target 'lint' failed

fix was pushed under one-liner rule

Pushed to ipa-4-3: afee95a82e13732fbdb72a6c07e8241da29154d0

From eba5169bd7c1c8c2bb9f6bf49c5c7aad78fcbcf7 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Tue, 28 Jun 2016 18:27:39 +0200
Subject: [PATCH] CA replica promotion: fix forgotten import

In IPA 4.3 branch we forgot to import ipalib.constants

https://fedorahosted.org/freeipa/ticket/5966
---
 ipaserver/install/cainstance.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ipaserver/install/cainstance.py b/ipaserver/install/cainstance.py
index 278514d06265455b49be8fb4dc5634592572efe8..fa92aec95be4e812b5764d98e0e331870b9fc90d 100644
--- a/ipaserver/install/cainstance.py
+++ b/ipaserver/install/cainstance.py
@@ -43,6 +43,7 @@ import pipes
 from six.moves import urllib
 from six.moves.configparser import ConfigParser, RawConfigParser
 
+import ipalib.constants
 from ipalib import api
 from ipalib import pkcs10, x509
 from ipalib import errors
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to