On 06/30/2016 01:57 PM, Pavel Vomacka wrote:
> 
> 
> On 06/29/2016 05:42 PM, Petr Vobornik wrote:
>> On 06/24/2016 12:40 PM, Pavel Vomacka wrote:
>>> Hello,
>>>
>>> please review attached patches, they add 'Delete Server' button.
>>>
>> 1. there is a whitespace warning while applying patch 63.
>>
>> 2. It breaks expectation of no_init.
>> Instead of
>>    var that = IPA.details_facet(spec);
>> Use
>>    var that = IPA.details_facet(spec, no_init);
>>
>> Then rename:
>>    that.init_facet = function() {
>> ẗo
>>    that.init_servers_facet = function() {
>>
>> Add there at beginning:
>>    that.init_details_facet
>>
>>
>> 3. IPA.action and IPA.delete_action has the functionality of
>> server_delete_action build-in, including redirection to server search
>> page which is missing in this patch.
>>
>> Updated patch with the issues fixed is attached.
>>
>> I did not test final version of the patch because my testing env. died.
> Thank you, everything works well.
> 
> ACK
> 

master:
* e65ce4fedc8e8e4f16c8d0c56f7618a84e8e7f85 Add support to change button
css class on confirm dialog
* 7f4de88ea1da11d4111a917672c0cb7ab9866c90 Add button for server-del command

-- 
Petr Vobornik

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to