On 06/16/2016 03:23 PM, Lenka Doudova wrote:
attached are tests for authentication indicators. Please note:
1. newly created service tracker is not exactly complete, list of
unimplemented methods is in doc. These methods can be filled in when
existing declarative tests are refactored.
2. patch 0015 depends on 0014, so it should not be pushed without it.
In the update method, what happens when the updated attributes contain
addattr? It is not clear to me. Is it necessary?
host1 and service2 do not tell anything about the purpose of the
fixture. Please assign more descriptive names to them.
Why do the fixtures have 'function' scope? Does the service entry exist
during the second and third test case?
Per offline discussion, admin user has no special privileges here, LGTM.
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code