Hello!

Thank you!

Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer


----- Original Message -----
From: "Martin Basti" <mba...@redhat.com>
To: "Ganna Kaihorodova" <gkaih...@redhat.com>
Cc: freeipa-devel@redhat.com
Sent: Thursday, July 21, 2016 8:03:53 PM
Subject: Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests



On 20.07.2016 18:17, Ganna Kaihorodova wrote:
> Hello!
>
> Thank you for review.
> I attached patch with fixed commit message
>
>
> Best regards,
> Ganna Kaihorodova
> Associate Software Quality Engineer
>
>
> ----- Original Message -----
> From: "Martin Basti" <mba...@redhat.com>
> To: "Ganna Kaihorodova" <gkaih...@redhat.com>, freeipa-devel@redhat.com
> Sent: Wednesday, July 20, 2016 5:04:47 PM
> Subject: Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin 
> tests
>
>
>
> On 20.07.2016 17:02, Ganna Kaihorodova wrote:
>> Greetings!
>>
>> Fix for ipatests/test_xmlrpc/test_dns_plugin.py
>>
>> Fix conflict between “got” and “expected” values when testing 
>> "dnsconfig_mod: Update global DNS settings"
>>
>> Best regards,
>> Ganna Kaihorodova
>> Associate Software Quality Engineer
>>
>>
>>
>>
> LGTM, but can you fix commit message?
>
> This looks very suspicious
>
> Subject: [PATCH 2/2] =?UTF-8?q?Fix=20conflict=20between=20=E2=80=9Cgot?=
>    =?UTF-8?q?=E2=80=9D=20and=20=E2=80=9Cexpected=E2=80=9D=20values=20when=20?=
>    =?UTF-8?q?testing=20"dnsconfig=5Fmod:=20Update=20global=20DNS=20settings"?=
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
>
> regards,
> Martin^2
ACK

I just replaced some fancy unicode quotation marks with ASCII in commit 
message before push

Pushed to master: 359cfeb7c6798038f5638f9d0977dda351f21431


-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to