On 07/29/2016 03:00 PM, Pavel Vomacka wrote:



On 07/28/2016 08:16 AM, Lenka Doudova wrote:



On 07/20/2016 04:51 PM, Pavel Vomacka wrote:
Please review attached patches, which add tests for new certificate widget in WebUI.

https://fedorahosted.org/freeipa/ticket/6064



Hi,
thanks for patches.
Functionally ok, but you have lots of PEP8 errors in patches 78, 80, 81 and 82 -> NACK. Also in patch 82, method test_arbitrary_certificate, comment says user needs to have "arbitrary_cert" configured, but the property in config file is correctly "arbitrary_cert_path", so it's a bit misleading.

Patch 79 is OK, ACK.

Lenka


Thank you for review. Attaching patches which have fixed all pep8 erros. Bad property of config file was also mentioned in patch 81. These are also fixed.

--
Pavel^3 Vomacka
Hi,

all is fine now, ACK for all patches.

Lenka
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to