On 11.8.2016 19:43, Martin Basti wrote:
On 11.08.2016 16:09, Jan Cholasta wrote:
On 11.8.2016 14:27, Martin Basti wrote:
On 01.08.2016 10:27, Jan Cholasta wrote:
On 1.8.2016 10:19, Jan Cholasta wrote:
Hi,
the attached patches fix
<https://fedorahosted.org/freeipa/ticket/6098>
and <https://fedorahosted.org/freeipa/ticket/6150>.
Self-NACK, proper patches attached.
Honza
IMHO this is caused by your patches, test_cert_plugin.py:
Fixed.
Updated and rebased patches attached.
Hello,
It works for me, but:
1)
Is this py2/3 compatible?
ra_obj = ra.get_certificate(str(serial_number))
I don't see why not. Do you have any particular incompatibility in mind?
2)
Are you sure you need tuple() here?
+ for key in tuple(six.iterkeys(result)):
Yes, I'm modifying `result` inside the loop.
I don't need the six.iterkeys() though.
3)
if cert is not None:
filter = ldap.make_filter_from_attr('usercertificate', value)
filters.append(filter)
Variable "value" may be referenced before assignment
Right, it should be `cert`, not `value`.
I haven't tested performace improvements yet, and it is quite big change
so I will continue with testing tomorrow.
Martin^2
--
Jan Cholasta
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
