Hello!

Thank you for review
Attached fixed patch

Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer


----- Original Message -----
From: "Martin Basti" <mba...@redhat.com>
To: "Ganna Kaihorodova" <gkaih...@redhat.com>, "freeipa-devel" 
<freeipa-devel@redhat.com>
Sent: Thursday, August 11, 2016 11:00:21 AM
Subject: Re: [Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests 
replication layouts



On 09.08.2016 16:55, Ganna Kaihorodova wrote:
> Hello!
>
> Domain level 0 doesn't allow to create replica file on CA master, testcase 
> was skipped with Domain level 0
>
> https://fedorahosted.org/freeipa/ticket/6134
>
> Best regards,
> Ganna Kaihorodova
> Associate Software Quality Engineer
>
>
>
>
Hello,

Please fix PEP8 error you introduced.
./ipatests/test_integration/test_replication_layouts.py:32:1: E302 
expected 2 blank lines, found 1

IMO this need skip on domain level 0 too
* Test2ConnectedTopologyWithoutCA
* TestDoubleCircleTopologyWithoutCA

Martin^2
From 9548a1974c3f872d808ebe521359dca2ee40ce97 Mon Sep 17 00:00:00 2001
From: Ganna Kaihorodova <gkaih...@redhat.com>
Date: Fri, 12 Aug 2016 13:14:10 +0200
Subject: [PATCH] Fix for integration tests replication layouts

Domain level 0 doesn't allow to create replica file on CA master, testcases were skipped with Domain level 0

[https://fedorahosted.org/freeipa/ticket/6134]
---
 ipatests/test_integration/test_replication_layouts.py | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/ipatests/test_integration/test_replication_layouts.py b/ipatests/test_integration/test_replication_layouts.py
index 9fd4ddca299ca99053aae17ae1d43d3c64650f40..c1788153032ffb9125bd9139e70adad78c78607e 100644
--- a/ipatests/test_integration/test_replication_layouts.py
+++ b/ipatests/test_integration/test_replication_layouts.py
@@ -3,10 +3,13 @@
 #
 
 import time
-
+import pytest
+from ipalib.constants import DOMAIN_LEVEL_0
+from ipatests.test_integration.env_config import get_global_config
 from ipatests.test_integration.base import IntegrationTest
 from ipatests.test_integration import tasks
 
+config = get_global_config()
 
 class LayoutsBaseTest(IntegrationTest):
 
@@ -27,6 +30,8 @@ class LayoutsBaseTest(IntegrationTest):
             r.run_command(['ipa', 'user-show', test_user])
 
 
+@pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0,
+                    reason='does not work on DOMAIN_LEVEL_0 by design')
 class TestLineTopologyWithoutCA(LayoutsBaseTest):
 
     num_replicas = 3
@@ -87,6 +92,8 @@ class TestCompleteTopologyWithCA(LayoutsBaseTest):
         self.replication_is_working()
 
 
+@pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0,
+                    reason='does not work on DOMAIN_LEVEL_0 by design')
 class Test2ConnectedTopologyWithoutCA(LayoutsBaseTest):
     num_replicas = 33
 
@@ -105,6 +112,8 @@ class Test2ConnectedTopologyWithCA(LayoutsBaseTest):
         self.replication_is_working()
 
 
+@pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0,
+                    reason='does not work on DOMAIN_LEVEL_0 by design')
 class TestDoubleCircleTopologyWithoutCA(LayoutsBaseTest):
     num_replicas = 29
 
-- 
2.7.4

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to