On 12.08.2016 12:37, Petr Spacek wrote:
please review attached patch set. It fixes
The code is also available on Github:
Martin Basti, please build it also in @freeipa/freeipa-master COPR so CI can
pick it up. Thank you!
Patch set description:
Fix zone removal to respect forward configuration inheritance.
Ad-hoc fwd_delete_table() calls did not respect inheritance hierarchy
in forwarding configuration. Now all manipulation with forward table
is done in fwd_configure_zone() and fully respects configuration inheritance.
There is a trick: When removing or deactivating a zone, fwd_configure_zone()
is called with empty configuration set to simulate that the zone does
not have any explicit configuration. This triggers the inheritance
logic when necessary (i.e. for the root zone).
Remove preserve_forwarding parameter from ldap_delete_zone2().
The parameter was TRUE only when called from zone_security_change().
zone_security_change() is calling ldap_delete_zone2() in exclusive mode
anyway so there is no need to optimize this.
Removal of the parameter will make easier to centralize forwarding
configuration on one place.
Works for me, but I haven't checked the code.
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code